Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make synchronizer a context manager for managing event loop life cycle explicitly #158

Closed
wants to merge 2 commits into from
Closed

Make synchronizer a context manager for managing event loop life cycle explicitly #158

wants to merge 2 commits into from

Conversation

freider
Copy link
Contributor

@freider freider commented Aug 23, 2024

Can also still be used lazily for usages outside of context manager

An advantage of using the context manager is that the event loop can be cleaned up gracefully before the interpreter shuts down, preventing issues with "trying to schedule call after executor shutdown" and other shutdown races/warnings.

freider added 2 commits August 23, 2024 08:38
@freider
Make synchronizer a context manager for managing event loop life cycl…
b87c571 
…e explicitly

Can also be used lazily for usages outside of context manager
@freider
lint
b618bbe
@freider
Copy link
Contributor Author

freider commented Feb 11, 2025

No longer sure about the merits of this. Might as well just do:

try:
    # run code
finally:
    synchronizer._close_loop()

Can pick this up again in the future if we need it. Closing for now

@freider freider closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@freider